Enable including libraries with a preamble in the browser directly #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutating the self variable with Object.create on the window global makes objects included on js.context within Dart unavailable in the browser environment. Fix this issue by only preventing encapsulation via Object.create when necessary and not in the browser. Additionally, browsers tend to not have CommonJS globals available. To prevent ReferenceErrors when running in the browser, check if these globals are available before setting them on self.
Use globalThis which is the standard way to access the global this Check for Node.js explicitly to eliminate specific service worker and Electron checks
mnito
changed the title
nex3
approved these changes
Feb 22, 2023
|
Thanks for the fix! Sorry for the long delay! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mutating the self variable with Object.create on the window global makes objects included on js.context within Dart unavailable in the browser environment. Fix this issue by only preventing encapsulation via Object.create when necessary and not in the browser.
Additionally, browsers tend to not have CommonJS globals available. To prevent ReferenceErrors when running in the browser, check if these globals are available before setting them on self.
EDIT: Did a slightly larger refactor of the Node.js and global check with the second commit, to address #28 and support service workers