-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bot software to track votes and score #9
Comments
https://github.com/jirwin/treslek-github seems like a good place to start. |
Should votes be reset when the PR gets a comment? |
The votes should only have an effect when the PR reaches quorum. Computing the vote's whole score from scratch on each new comment would work. An active player should be allowed to comment on a PR multiple times, but only have one vote (their last one cast chronologically?) Scores don't change until a vote is completed (and thus, commenting is locked and votes are tallied). |
Let me try and explain the situation I'm concerned with: 3 active players: 1, 2, 3 Player 1 submits a proposal. At this point every player has voted(assuming the author gets an automatic +1), but Player 2 has voted +1 for a different rule. My thought is that after each time the sha1 changes(commit, force push), the quorum counter should be reset so that we know every user has voted on the most recent version of the proposal. |
Oh wow, you're absolutely right. Rebasing or committing over top the original file should nullify previous votes. So ya, we should recompute. I can also imagine it getting tricky to read top-to-bottom if there are commit edit mid-way though voting. We should encourage meta discussion be separate comments from votes, so that they don't get intermixed too much. |
To this point, I think we should make votes be only |
+1 |
https://github.com/jirwin/treslek-nomic Currently this will get the active players, and parse the scores. TODO
|
possible inspiration: |
N
% of active Players having Voted.N
is currently100
.Pull Requests
When Quorum is reached,
total for
,total against
,% for
,% against
,winning side
, etc}/(+|-)1/
SCOREBOARD.rb
.0
points don't need to be listed.The text was updated successfully, but these errors were encountered: