Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation Bug #1433

Closed
SupremeMortal opened this issue Sep 14, 2014 · 16 comments
Closed

Generation Bug #1433

SupremeMortal opened this issue Sep 14, 2014 · 16 comments

Comments

@SupremeMortal
Copy link

SupremeMortal commented Sep 14, 2014

When I generate the world for the first time, the chunk next to where I spawn always is buggy like this:

I have done this 5 times consecutively.

@Masy
Copy link
Contributor

Masy commented Sep 14, 2014

When this is the 0 0 Chunk, then change that, MCServer has some problems when the spawn is in that chunk...

@Howaner Howaner added the bug label Sep 14, 2014
@archshift archshift added this to the Generator milestone Sep 15, 2014
@parabyte
Copy link

im seeing this bug too

@AedDev
Copy link

AedDev commented Sep 26, 2014

It's not a bug, it's a feature - a swimmingpool! 😉

@madmaxoft
Copy link
Member

I can't reproduce this. I've tried 5 times and each time the world generates okay.

Can you give me the world seed from your world.ini?

@NiLSPACE
Copy link
Member

Most of the times it works normaly, but sometimes I get this as well.

@parabyte
Copy link

[Seed]
Seed=-723052804

@parabyte
Copy link

2014-09-26_13 25 06

[Seed]
Seed=797167698

@madmaxoft
Copy link
Member

I tried both those seeds, each with an empty world, and still they both generated alright. If you walk into that bad chunk and issue a /regeneratechunk command, does it regenerate properly or does it stay this weird?

@NiLSPACE
Copy link
Member

When you use /regen it generates normaly.

@Masy
Copy link
Contributor

Masy commented Sep 26, 2014

not everytime, Howaner and i had a chunk (in the jungle/ocean, don't know if that matters) and it regenerated a hole chunk filled with warter until y = 64 everytime i executed /regen

@madmaxoft
Copy link
Member

Could it be that only release-mode executables suffer from this issue? I've never actually seen this happen, and the only difference I can think of is that I'm always using a debug build.

@madmaxoft
Copy link
Member

Finally, I got the bug! At least I hope so, because this one's massive:
2014-10-02_22 00 24
All in all, about 20 chunks mis-generated. But this way it even hinted at what the problem is. The mis-generated chunks form a path from chunk [0, 0] in the X+, Z+ direction, randomly choosing which one to take. @tigerw sounds familiar? https://github.com/mc-server/MCServer/blame/master/src/World.cpp#L697-L704

@NiLSPACE
Copy link
Member

NiLSPACE commented Oct 2, 2014

Wow I've never seen it this big. It's usualy only 0, 0 when it happens to me.

@madmaxoft
Copy link
Member

And after erasing the world and re-trying, the bug's gone again :(

@NiLSPACE
Copy link
Member

NiLSPACE commented Oct 2, 2014

Yea, as said earlier the bug occurs rather irregularly. :S

@tigerw
Copy link
Member

tigerw commented Oct 2, 2014

@tigerw sounds familiar? https://github.com/mc-server/MCServer/blame/master/src/World.cpp#L697-L704

Well, it seems like you last changed it...

@bearbin bearbin removed the bug label Oct 3, 2014
@bearbin bearbin removed this from the Generator milestone Oct 12, 2014
@SupremeMortal SupremeMortal removed this from the Generator milestone Oct 12, 2014
madmaxoft added a commit that referenced this issue Nov 30, 2014
This was probably the original cause for the "empty chunks".
Fixes #1433.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants