Renamed cFinishGenSingleBiomeSingleTopBlock to cFinishGenSingleTopBlock #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now accepts a vector of biomes and a vector of allowed blocks.
| // Returns true if the given blocktype may be below m_BlockType | ||
| bool IsAllowedBlockBelow(BLOCKTYPE a_BlockBelow) | ||
| { | ||
| for (BlockList::iterator itr = m_AllowedBelow.begin(); itr != m_AllowedBelow.end(); ++itr) |
There was a problem hiding this comment.
I think you can change this to a std::find.
|
Do not use /** Each allowed biome has a true value here, all the others are false. */
bool m_IsBiomeAllowed[256];
inline bool IsAllowedBiome(EMCSBiome a_Biome)
{
return m_IsBiomeAllowed[a_Biome];
} |
Slander! Misrepresentation of the truth! Compilation failed. |
|
How can I create a flat array? |
|
That's the first declaration in my code example, |
|
How did I not see that part. Sorry :S |
|
Done. |
| @@ -456,12 +456,12 @@ void cFinishGenIce::GenFinish(cChunkDesc & a_ChunkDesc) | |||
| //////////////////////////////////////////////////////////////////////////////// | |||
| // cFinishGenLilypads: | |||
|
|
|||
| int cFinishGenSingleBiomeSingleTopBlock::GetNumToGen(const cChunkDef::BiomeMap & a_BiomeMap) | |||
| int cFinishGenSingleTopBlock::GetNumToGen(const cChunkDef::BiomeMap & a_BiomeMap) | |||
There was a problem hiding this comment.
Change the comment above, too, will you?
|
Done |
| AllowedBiomes.push_back(biMesaPlateauFM); | ||
| AllowedBiomes.push_back(biMesaPlateauM); | ||
|
|
||
| // A list with all the allowed blocks that can be below the lilypad. |
There was a problem hiding this comment.
lilypad -> dead bush (or death bush? :)
Removed whitespace fixed dead bush comment
|
Done |
madmaxoft
added a commit
that referenced
this pull request
Jul 29, 2014
Renamed cFinishGenSingleBiomeSingleTopBlock to cFinishGenSingleTopBlock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now accepts a vector of biomes and a vector of allowed blocks.
Also the deadbushes finisher generates in mesa biomes as well.