Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PathFinder - Fixed Howaner's bug #1932

Merged
merged 1 commit into from May 3, 2015
Merged

PathFinder - Fixed Howaner's bug #1932

merged 1 commit into from May 3, 2015

Conversation

SafwatHalaby
Copy link
Member

Fixes this.

@madmaxoft
Copy link
Member

I'd leave the assert at the top of the function, but check the a_Chunk instead. Or even better, pass the chunk as a reference, that can never be nullptr; then assign as m_Chunk = &a_Chunk

@SafwatHalaby
Copy link
Member Author

Will do. Last time I tried this, there was a weird issue with Chunk references and the = operator. (But the ref might have been on the left hand, I'm not sure.)

@madmaxoft
Copy link
Member

This looks good, merge if it compiles.

@SafwatHalaby
Copy link
Member Author

Let me squash it first.

@SafwatHalaby
Copy link
Member Author

OK to merge.

madmaxoft added a commit that referenced this pull request May 3, 2015
PathFinder - Fixed Howaner's bug
@madmaxoft madmaxoft merged commit d757d75 into cuberite:master May 3, 2015
@SafwatHalaby SafwatHalaby mentioned this pull request May 3, 2015
@SafwatHalaby SafwatHalaby deleted the F_AssertFix branch May 6, 2015 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants