-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github] PR Decoration - Annotation on wrong line #189
Labels
bug
Something isn't working
Comments
cncgoko
added a commit
to cncgoko/sonarqube-community-branch-plugin
that referenced
this issue
Jun 11, 2020
Fix proposal for mc1arke#189 On Github PR decoration, annotation for single line issues are reported on the wrong line, because end line of the annotated error is incremented by one.
cncgoko
added a commit
to cncgoko/sonarqube-community-branch-plugin
that referenced
this issue
Jun 11, 2020
Fix mc1arke#189 - Annotation on wrong line
cncgoko
added a commit
to cncgoko/sonarqube-community-branch-plugin
that referenced
this issue
Jun 11, 2020
Fix proposal for mc1arke#189 On Github PR decoration, annotation for single line issues are reported on the wrong line, because end line of the annotated error is incremented by one.
If you think you have a potential fix and can prove it resolves the issue then feel free to submit a Pull Request. |
mc1arke
pushed a commit
that referenced
this issue
Jun 27, 2020
On Github Pull Request decoration, annotation for single line issues are reported on the wrong line, because end line of the annotated error is incorrectly incremented by one.
This can be closed. |
mc1arke
pushed a commit
that referenced
this issue
Jul 16, 2020
On Github Pull Request decoration, annotation for single line issues are reported on the wrong line, because end line of the annotated error is incorrectly incremented by one. (cherry picked from commit 79f6c5a)
mc1arke
pushed a commit
that referenced
this issue
Jul 16, 2020
On Github Pull Request decoration, annotation for single line issues are reported on the wrong line, because end line of the annotated error is incorrectly incremented by one. (cherry picked from commit 79f6c5a)
The fix has been released in 1.3.2 of the plugin (Sonarqube 7.8-8.0) and 1.4.0 (Sonarqube 8.1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
On Github PR decoration, annotation for single line issues are reported on the wrong line, because end line of the annotated error is incremented by one.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Annotation should be made on the last line of the issue. If the issue is single lined, the annotation should be made on that single line.
Screenshots
No screenshot available
Software Versions
Additional context
The issue seems to come from line
sonarqube-community-branch-plugin/src/main/java/com/github/mc1arke/sonarqube/plugin/ce/pullrequest/github/v4/GraphqlCheckRunProvider.java
Line 230 in 230d84e
I'm not sure if it's by design, or any requirement from Github API, but there is a suspicious
+ 1
that can be the cause of this issueThe text was updated successfully, but these errors were encountered: