Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview flag required in Azure Devops Server (on-premise) for certain API calls #442

Closed
jbaehr-phoenis opened this issue Sep 14, 2021 · 1 comment
Closed

Preview flag required in Azure Devops Server (on-premise) for certain API calls #442

jbaehr-phoenis opened this issue Sep 14, 2021 · 1 comment
Labels
awaiting release Merged but not currently in release vesrion bug Something isn't working

Comments

@jbaehr-phoenis
Copy link

Describe the bug
On Azure-Devops-Server (the on-premise version of Azure Devops) certain API calls need the "-preview" flag added to the api version.
Namely the "Pull Request Statuses API".

To Reproduce
Steps to reproduce the behavior:
Use features that call the "Pull Request Statuses API" in the Azure Devops Api handler.

Expected behavior
The call should succeed.

Screenshots
Not really a screenshot but a log file (from the discussion in the pr mentioned below):
sonarqube_ce.log

Software Versions

  • SonarQube Version: irrelevant
  • Plugin Version: latest

Additional context
This issue was raised as a result of discussing the proposed fix/changes in PR #438
@jbaehr-phoenis jbaehr-phoenis added the bug Something isn't working label Sep 14, 2021
mc1arke added a commit that referenced this issue Oct 4, 2021
@mc1arke
#442: Pass preview flag on Azure Devops status requests
a0a67ab 
Azure DevOps on-premise responds with an error if the `-preview` is not appended to the version number during the request to submit the pipeline status during Pull Request decoration. As the use of a preview version for this call does not seem to adversely affect invocation of this endpoint on Azure DevOps Cloud, the `-preview` flag has been unconditionally added to the status update, although it has not been added to any other invocations since they do not encounter the same error.
mc1arke added a commit that referenced this issue Oct 4, 2021
@mc1arke
#442: Pass preview flag on Azure Devops status requests
46354b7 
Azure DevOps on-premise responds with an error if the `-preview` is not appended to the version number during the request to submit the pipeline status during Pull Request decoration. As the use of a preview version for this call does not seem to adversely affect invocation of this endpoint on Azure DevOps Cloud, the `-preview` flag has been unconditionally added to the status update, although it has not been added to any other invocations since they do not encounter the same error.
@mc1arke mc1arke added awaiting release Merged but not currently in release vesrion backport candidate This feature or fix should be included in another release branch labels Oct 4, 2021
@mc1arke mc1arke mentioned this issue Dec 14, 2021
Closed
@mc1arke
Copy link
Owner

mc1arke commented Dec 18, 2021

Released in 1.10.0 of the plugin

@mc1arke mc1arke closed this as completed Dec 18, 2021
mc1arke added a commit that referenced this issue Jun 19, 2022
@mc1arke
#442: Pass preview flag on Azure Devops status requests
1ff873f 
Azure DevOps on-premise responds with an error if the `-preview` is not appended to the version number during the request to submit the pipeline status during Pull Request decoration. As the use of a preview version for this call does not seem to adversely affect invocation of this endpoint on Azure DevOps Cloud, the `-preview` flag has been unconditionally added to the status update, although it has not been added to any other invocations since they do not encounter the same error.

(cherry picked from commit 46354b7)
mc1arke added a commit that referenced this issue Jun 19, 2022
@mc1arke
#442: Pass preview flag on Azure Devops status requests
49a98fd 
Azure DevOps on-premise responds with an error if the `-preview` is not appended to the version number during the request to submit the pipeline status during Pull Request decoration. As the use of a preview version for this call does not seem to adversely affect invocation of this endpoint on Azure DevOps Cloud, the `-preview` flag has been unconditionally added to the status update, although it has not been added to any other invocations since they do not encounter the same error.

(cherry picked from commit 46354b7)
@mc1arke mc1arke removed the backport candidate This feature or fix should be included in another release branch label Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
awaiting release Merged but not currently in release vesrion bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mc1arke @jbaehr-phoenis