Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply appropriate casing to CommentThreadStatus property names #441

Merged
merged 1 commit into from Sep 13, 2021

Conversation

jcuzzi
Copy link
Contributor

@jcuzzi jcuzzi commented Sep 13, 2021

Fixes #439

@jcuzzi
Copy link
Contributor Author

jcuzzi commented Sep 13, 2021

Either way works. I think this way makes it more fool proof, but it is up to you.

@mc1arke
Copy link
Owner

mc1arke commented Sep 13, 2021

Part of the reason I'm suggesting changing the enum is that any serialised value produced by the service wont work after your change, since they wont match the possibly values supported by the API. We don't currently serialise these enum values so it's not currently causing an issue, but it's something we should fix in the right way if we can.

@jcuzzi jcuzzi changed the title Enable ACCEPT_CASE_INSENSITIVE_ENUMS for Azure DevOps Apply appropriate casing to CommentThreadStatus property names Sep 13, 2021
@mc1arke mc1arke merged commit 4049305 into mc1arke:master Sep 13, 2021
@mc1arke
Copy link
Owner

mc1arke commented Sep 13, 2021

Merged, thanks for the quick turn-around on the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure DevOps : exception deserializing comment thread
2 participants