Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

McMMOEntityDamageByRuptureEvent missing #getHandlerList() #4972

Closed
Indyuce opened this issue Feb 19, 2024 · 1 comment
Closed

McMMOEntityDamageByRuptureEvent missing #getHandlerList() #4972

Indyuce opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels

Comments

@Indyuce
Copy link

Indyuce commented Feb 19, 2024

The event class McMMOEntityDamageByRuptureEvent is missing a static method getHandlerList(). It does implement getHandlers() but it's missing a static method to get the handler list.

This method must have been omitted in the most recent update reworking the events. Back when the class implemented EntityDamageByEntityEvent, this subclass didn't have to implement that method as it inherited the method from its parent class. It's not the case anymore since it has its own handler list, it's not the one from EntityDamageEvent

This makes it impossible to use event registration methods from the Bukkit PluginManager class. Even worse any plugin trying to do so will crash their plugin on bootup

[16:19:35 ERROR]: Error occurred while enabling MythicLib v1.6.2-SNAPSHOT (Is it up to date?)
org.bukkit.plugin.IllegalPluginAccessException: Unable to find handler list for event org.bukkit.event.entity.EntityEvent. Static getHandlerList method required!
        at io.papermc.paper.plugin.manager.PaperEventManager.getRegistrationClass(PaperEventManager.java:124) ~[paper-1.20.4.jar:git-Paper-430]
        at io.papermc.paper.plugin.manager.PaperEventManager.getRegistrationClass(PaperEventManager.java:122) ~[paper-1.20.4.jar:git-Paper-430]
        at io.papermc.paper.plugin.manager.PaperEventManager.registerEvents(PaperEventManager.java:84) ~[paper-1.20.4.jar:git-Paper-430]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.registerEvents(PaperPluginManagerImpl.java:131) ~[paper-1.20.4.jar:git-Paper-430]
        at org.bukkit.plugin.SimplePluginManager.registerEvents(SimplePluginManager.java:670) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.lumine.mythic.lib.comp.McMMOModule.<init>(McMMOModule.java:31) ~[MythicLib-1.6.2-SNAPSHOT.jar:?]
        at io.lumine.mythic.lib.MythicLib.onEnable(MythicLib.java:191) ~[MythicLib-1.6.2-SNAPSHOT.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:287) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:188) ~[paper-1.20.4.jar:git-Paper-430]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104) ~[paper-1.20.4.jar:git-Paper-430]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507) ~[paper-api-1.20.4-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugin(CraftServer.java:639) ~[paper-1.20.4.jar:git-Paper-430]
        at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugins(CraftServer.java:550) ~[paper-1.20.4.jar:git-Paper-430]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:671) ~[paper-1.20.4.jar:git-Paper-430]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:431) ~[paper-1.20.4.jar:git-Paper-430]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:309) ~[paper-1.20.4.jar:git-Paper-430]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1131) ~[paper-1.20.4.jar:git-Paper-430]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:319) ~[paper-1.20.4.jar:git-Paper-430]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]
@nossr50
Copy link
Member

nossr50 commented Feb 19, 2024

Oof, thanks for noticing this, will fix it.

@nossr50 nossr50 self-assigned this Feb 19, 2024
@nossr50 nossr50 pinned this issue Feb 19, 2024
@nossr50 nossr50 unpinned this issue Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants