Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the example for Place.details #36

Merged
merged 4 commits into from
Feb 19, 2021
Merged

Fix the example for Place.details #36

merged 4 commits into from
Feb 19, 2021

Conversation

vasco3
Copy link
Contributor

@vasco3 vasco3 commented Feb 17, 2021

the example is shown as an async/await but it is missing the keywords.
I rewrote it with a promise, so it matches the Places Autocomplete example

Jorge Cuadra added 2 commits February 17, 2021 17:16
the example is shown as an async/await but it is missing the keywords.
I rewrote it with a promise, so it matches the Places Autocomplete example
@mcabs3
Copy link
Owner

mcabs3 commented Feb 19, 2021

Thanks for taking the time to look at this project. I always appreciate the help maintaining it. I am currently working (and almost finishing) a v2 which will use a different syntax/pattern so these docs will be obsolete.

I actually prefer using the async/await form in my readme so its easier for people to see, but yes I am making an assumption that their code is in an environment that supports it (and in an async function).

If you would like to update the autocomplete example to use async/await that would be a big help.

@vasco3
Copy link
Contributor Author

vasco3 commented Feb 19, 2021

no problem, updated.

@mcabs3 mcabs3 merged commit 9d9a317 into mcabs3:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants