Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in gunique docs #42

Closed
felixholub opened this issue Jul 17, 2018 · 0 comments
Closed

Typo in gunique docs #42

felixholub opened this issue Jul 17, 2018 · 0 comments
Assignees
Labels

Comments

@felixholub
Copy link

https://gtools.readthedocs.io/en/latest/usage/gunique/index.html#stored-results
r(unique), not r(nunique) yields the number of groups. In the Stata help file this is correct.

@mcaceresb mcaceresb self-assigned this Jul 17, 2018
@mcaceresb mcaceresb added the bug label Jul 17, 2018
mcaceresb added a commit that referenced this issue Jul 21, 2018
Features

* Adds `gduplicates` as a replacement of `duplicates`. This is
  basically a wrapper for `gegen tag` and `gegen count`.
* `fasterxtile` and `gquantiles` now accept weights (including `by()`)
* Note that stata might not handle weights accurately in pctile
  and xtile (or, at the very least, it does not seem to follow its
  documented formulas in all cases).
* `strL` partial support (long strings only).
* Option `compress` tries to recast strL variables as str#
* Option `forcestrl` ignores binary values check (use with caution).
* Fixes #31
  (added option `mlast` to `hashsort` to imitate `gsort` when sorting
  numbers in inverse order and they contain missing values).

Bug Fixes

* `semean` returns missing with fewer than 2 observations.
* If `strL` contains binary data `gtools` functions now throw an error.
* `strL` missing values now read correctly.
* Added `strL`-specific tests
* Closes #39 `strL` partial
  support.
* Closes #41 `wild` with
  existing variables gets a warning.
* Fixes #42 `gunique` typo.

Enhancements

* `_gtools_internals.ado` exits when `GTOOLS_CALLER` is empty.

Tests

* All passing in Stata 13 in Linux, Windows
* All passing in Stata 15 in Linux, Windows
* All passing in Stata 14 in OSX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants