Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated syn and quote to 0.15 and 0.6. #26

Merged
merged 16 commits into from
Oct 20, 2018

Conversation

azriel91
Copy link
Contributor

@azriel91 azriel91 commented Oct 16, 2018

Issue #25

Oh ya, assuming you're accepting this PR, do you want the rustfmt.toml deleted or kept?
rustfmt 0.99.5-nightly (90692a5 2018-09-26) panics with the values present

@azriel91 azriel91 force-pushed the maintenance/25/bump-syn-and-quote branch from 9da95ec to f1abbef Compare October 17, 2018 02:43
@azriel91
Copy link
Contributor Author

azriel91 commented Oct 17, 2018

Ready for review!
All tests (except the compile fail ones) pass; I'm super happy you've got so many automated tests, allows me the confidence to fearlessly hack away ⚔️

@azriel91
Copy link
Contributor Author

Hiya, so I managed to fix the derive-partial-eq compile fail test, but the derive-copy-clone test is not possible to be fixed, as a custom derive is a proc_macro_derive, whereas only proc_macro_attributes can see derive(..)s: dtolnay/syn#433.

I've used this in a fairly large project (a game that uses Amethyst), and it works as expected. There is heavy usage of derivative in the gfx crate, which is where I discovered and fixed the tricky issues.

@mcarton mcarton merged commit 152b329 into mcarton:master Oct 20, 2018
@mcarton
Copy link
Owner

mcarton commented Oct 20, 2018

Thanks you very much for this!
I have been meaning to do this for ever, but never had time to do it because there were so many changes.
I will remove the broken test as it is indeed not possible to get it to work any more.

@azriel91 azriel91 deleted the maintenance/25/bump-syn-and-quote branch October 20, 2018 22:54
@azriel91
Copy link
Contributor Author

woo all good! Your code's high quality 👌 so it makes it easier to jump in.
fun fact, it was easier fixing the number of errors from 114 to 20, than from 2 to 0 😂

kankri pushed a commit to kankri/rust-derivative that referenced this pull request Aug 23, 2019
…nd-quote

Updated `syn` and `quote` to `0.15` and `0.6`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants