no support for empty credentials

[meeech]

hi. a bit new to poking around with ldap, but I think I found a problem. Trying to leave credentials blank (anonymous usage)
but here:
https://github.com/mcavage/node-ldapjs/blob/master/lib/client/client.js#L468

assert.string(credentials, 'credentials');

but a few lines down, there is support for credentials being falsy
https://github.com/mcavage/node-ldapjs/blob/master/lib/client/client.js#L480

var req = new BindRequest({
    name: name || '',
    authentication: 'Simple',
    credentials: credentials || '',
    controls: controls
  });

So before i do a pr removing the assert, wanted to check with you.

[pfmooney]

I would have to double-check the LDAP spec but using assert.optionalString would probably do the trick.

[ssteffl]

i would like this too.

[ssteffl]

i am trying to query with anonymous credetials but am getting this error from teh server:

OperationsError: 000004DC: LdapErr: DSID-0C0906E8, 
comment: In order to perform this operation a successful bind must be completed on the connection., data 0, v1db1  

does this mean the server does not allow anonymous credentials? my binding code looks like this:

var c = ldapjs.createClient({
    url: //the server uri 
    maxConnections:50,
});
c.bind('', '', function(err){ if(err) throw new Error(err); });

[samypr100]

When is this going to be released as a tag? I'm using full repo url on npm due to this fix.

[jsumners]

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.