Decode utf8 strings as whole, not in parts, fixes #774 #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the PR. Could you please write a test for this? Prefix the test name with 'GH-774'. |
|
Test case added. |
| } | ||
|
|
||
| req.body = new Buffer(0); | ||
| return (function (chunk) { | ||
| req.body = Buffer.concat([req.body, chunk]); | ||
| if (chunk) |
There was a problem hiding this comment.
Please add braces around this if block -- since you've got braces around the else block
This was referenced Apr 26, 2015
|
Any news on integrating this? I see someone else is also hitting this. Thanks! |
yunong
added a commit
that referenced
this pull request
May 19, 2015
Decode utf8 strings as whole, not in parts, fixes #774
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.