Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_date_games function not pulling games before game id 021800110 #5

Closed
mcbarlowe opened this issue May 15, 2019 · 3 comments
Closed

get_date_games function not pulling games before game id 021800110 #5

mcbarlowe opened this issue May 15, 2019 · 3 comments
Assignees
@mcbarlowe
Labels
bug Something isn't working

Comments

@mcbarlowe
Copy link
Owner

mcbarlowe commented May 15, 2019 •
edited
Loading

The get_date_games function in scrape_functions module is not pulling the early season game_ids for the 2019 season. I discovered this in writing integration tests for the function. I'm assigning this to me but if someone wants to jump on it I'd be happy to accept a pull request. @HarryShomer if you have any advice that would help but if you're busy don't worry I'll handle it. Will need all tests to pass in the test_integration.py file before merging into master
@mcbarlowe mcbarlowe added the bug Something isn't working label May 15, 2019
@mcbarlowe mcbarlowe changed the title get_date_games function not pulling games before game id 021800110 get_date_games function not pulling games before game id 021800110 May 15, 2019
@mcbarlowe mcbarlowe self-assigned this May 15, 2019
@HarryShomer
Copy link
Contributor

I'll take a look now

@mcbarlowe
Copy link
Owner Author

I just pushed latest test to travis branch if you want to work there that will have all the tests you need

HarryShomer added a commit to HarryShomer/nba_scraper that referenced this issue May 15, 2019
@HarryShomer
Fixes mcbarlowe#5
6e24b2c
mcbarlowe added a commit that referenced this issue May 15, 2019
@mcbarlowe
Merge pull request #6 from HarryShomer/travis
ff87b41 
Fix for Issue #5
@mcbarlowe
Copy link
Owner Author

I will pull this fix into master after all the unit tests are written or until someone complains about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcbarlowe mcbarlowe

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcbarlowe @HarryShomer