fix: use None as sentinel value for output option

mcbeet · Jan 8, 2022 · 6a19653 · 6a19653
1 parent fa21c6e
commit 6a19653
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 15 deletions.
diff --git a/beet/toolchain/config.py b/beet/toolchain/config.py
@@ -73,7 +73,7 @@ class ProjectConfig(BaseModel):
 
     directory: str = ""
     extend: List[str] = Field(default_factory=list)
-    output: str = ""
+    output: Optional[str] = None
     ignore: List[str] = Field(default_factory=list)
     whitelist: Optional[List[str]] = None
 

diff --git a/tests/snapshots/config__config_resolution_crazy_extend__0.beet-config b/tests/snapshots/config__config_resolution_crazy_extend__0.beet-config
@@ -36,7 +36,7 @@
       "version": "",
       "directory": "tests/config_examples/crazy_extend",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": null,
       "require": [],
@@ -75,7 +75,7 @@
       "version": "",
       "directory": "tests/config_examples/crazy_extend",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": null,
       "require": [],
@@ -117,7 +117,7 @@
       "version": "",
       "directory": "tests/config_examples/crazy_extend/src",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": null,
       "require": [],

diff --git a/tests/snapshots/config__config_resolution_empty__0.beet-config b/tests/snapshots/config__config_resolution_empty__0.beet-config
@@ -6,7 +6,7 @@
   "version": "",
   "directory": "tests/config_examples/empty",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [],
   "whitelist": null,
   "require": [],

diff --git a/tests/snapshots/config__config_resolution_extend_everything__0.beet-config b/tests/snapshots/config__config_resolution_extend_everything__0.beet-config
@@ -6,7 +6,7 @@
   "version": "foo",
   "directory": "tests/config_examples/extend_everything",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [
     "base",
     "thing"

diff --git a/tests/snapshots/config__config_resolution_load_pack__0.beet-config b/tests/snapshots/config__config_resolution_load_pack__0.beet-config
@@ -6,7 +6,7 @@
   "version": "",
   "directory": "tests/config_examples/load_pack",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [],
   "whitelist": null,
   "require": [],

diff --git a/tests/snapshots/config__config_resolution_load_with_templates__0.beet-config b/tests/snapshots/config__config_resolution_load_with_templates__0.beet-config
@@ -6,7 +6,7 @@
   "version": "",
   "directory": "tests/config_examples/load_with_templates",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [],
   "whitelist": null,
   "require": [],

diff --git a/tests/snapshots/config__config_resolution_nested__0.beet-config b/tests/snapshots/config__config_resolution_nested__0.beet-config
@@ -6,7 +6,7 @@
   "version": "",
   "directory": "tests/config_examples/nested",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [],
   "whitelist": null,
   "require": [],
@@ -38,7 +38,7 @@
       "version": "",
       "directory": "tests/config_examples/nested",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": null,
       "require": [],

diff --git a/tests/snapshots/config__config_resolution_whitelist__0.beet-config b/tests/snapshots/config__config_resolution_whitelist__0.beet-config
@@ -6,7 +6,7 @@
   "version": "",
   "directory": "tests/config_examples/whitelist",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [],
   "whitelist": [
     "foo",

diff --git a/tests/snapshots/config__config_resolution_whitelist_nested__0.beet-config b/tests/snapshots/config__config_resolution_whitelist_nested__0.beet-config
@@ -6,7 +6,7 @@
   "version": "",
   "directory": "tests/config_examples/whitelist_nested",
   "extend": [],
-  "output": "",
+  "output": null,
   "ignore": [],
   "whitelist": [
     "foo",
@@ -43,7 +43,7 @@
       "version": "",
       "directory": "tests/config_examples/whitelist_nested",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": [
         "other"
@@ -80,7 +80,7 @@
       "version": "",
       "directory": "tests/config_examples/whitelist_nested",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": null,
       "require": [],
@@ -114,7 +114,7 @@
       "version": "",
       "directory": "tests/config_examples/whitelist_nested",
       "extend": [],
-      "output": "",
+      "output": null,
       "ignore": [],
       "whitelist": [
         "foo",