fix: rename pack image

mcbeet · May 5, 2021 · a3007a1 · a3007a1
1 parent f57ea93
commit a3007a1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/beet/library/base.py b/beet/library/base.py
@@ -343,7 +343,7 @@ class Pack(MatchMixin, MergeMixin, Container[str, NamespaceType]):
     mcmeta: ExtraPin[JsonFile] = ExtraPin(
         "pack.mcmeta", default_factory=lambda: JsonFile({})
     )
-    image: ExtraPin[Optional[PngFile]] = ExtraPin("pack.png", default=None)
+    icon: ExtraPin[Optional[PngFile]] = ExtraPin("pack.png", default=None)
 
     description: PackPin[TextComponent] = PackPin("description", default="")
     pack_format: PackPin[int] = PackPin("pack_format", default=0)
@@ -362,7 +362,7 @@ def __init__(
         zipfile: Optional[ZipFile] = None,
         zipped: bool = False,
         mcmeta: Optional[JsonFile] = None,
-        image: Optional[PngFile] = None,
+        icon: Optional[PngFile] = None,
         description: Optional[str] = None,
         pack_format: Optional[int] = None,
     ):
@@ -375,8 +375,8 @@ def __init__(
 
         if mcmeta is not None:
             self.mcmeta = mcmeta
-        if image is not None:
-            self.image = image
+        if icon is not None:
+            self.icon = icon
         if description is not None:
             self.description = description
         if pack_format is not None:

diff --git a/tests/test_resource_pack.py b/tests/test_resource_pack.py
@@ -29,11 +29,11 @@ def test_empty(snapshot: SnapshotFixture, pack: ResourcePack):
 
 
 def test_empty_with_image():
-    pack = ResourcePack(image=PngFile(Image.new("RGB", (32, 32), color="blue")))
+    pack = ResourcePack(icon=PngFile(Image.new("RGB", (32, 32), color="blue")))
     assert pack
-    assert pack == ResourcePack(image=PngFile(Image.new("RGB", (32, 32), color="blue")))
-    assert pack != ResourcePack(image=PngFile(Image.new("RGB", (32, 32), color="red")))
-    assert pack != ResourcePack(image=PngFile(Image.new("RGB", (16, 16), color="blue")))
+    assert pack == ResourcePack(icon=PngFile(Image.new("RGB", (32, 32), color="blue")))
+    assert pack != ResourcePack(icon=PngFile(Image.new("RGB", (32, 32), color="red")))
+    assert pack != ResourcePack(icon=PngFile(Image.new("RGB", (16, 16), color="blue")))
     assert dict(pack) == {}