Lexer- and parser-relative require resolution #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the vmRequire functions for reading the lexer and parser during Typescript declaration generation. The git history indicates that problems in this area are due to slight misuse of the
require.resolve
function which returns a path string, not a module. Later changes worked around this problem in the case of the parser but limited the require to 'antlr4/index', 'antlr4', or the parserFile itself. Therefore any custom imports in the antlr grammar (for example, any require statement in the@header
section) could not be loaded, leading to generation problems.This PR simplifies require resolution by using
require.resolve
relative to the lexer and parser file to return the module path, and thenrequire
-ing that path. This should work in a general way, eliminating the need for the various conditions invmRequire
.