Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8/#39: Rework deny_remote / remove unknown_pts_as_local #45

Merged
merged 11 commits into from Feb 14, 2021

Conversation

mcdope
Copy link
Owner

@mcdope mcdope commented Feb 13, 2021

This reworks deny_remote handling to use process based checking.

Instead of checking utmp and hoping there is an entry for the current session, which there often isn't for virtual terminals, we now check the chain of parent processes. If any parent process is sshd or telnetd we deny authentication.

This renders unknown_pts_as_local obsolete - removed.

Closes #8 (again)
See #39

@mcdope mcdope marked this pull request as draft February 13, 2021 18:36
src/process.c Show resolved Hide resolved
@mcdope
Copy link
Owner Author

mcdope commented Feb 13, 2021

@mcdope mcdope marked this pull request as ready for review February 13, 2021 21:52
@mcdope mcdope merged commit ac725b6 into master Feb 14, 2021
@mcdope mcdope deleted the issue-8-rework-deny_remote-option branch February 14, 2021 11:49
@mcdope mcdope linked an issue Feb 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remote sudo password bypass via vim Bug: deny_remote seems to prevent non-tty-sessions on Ubuntu
1 participant