Support for creating binary (bytes) parsers (Python 3 only) #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suggestion for supporting creation of parsers for parsing binary data by creating simpleparse.Parser from binary (bytes) declaration string instead of python standard string (str) type. Precondition: ============= - simpleparse Python 2 support ended
Suggestion for supporting creation of parsers for parsing binary data by creating simpleparse.Parser from binary (bytes) declaration string instead of python standard string (str) type. Precondition: ============= - simpleparse Python 2 support ended
|
@mcfletch how likely is it that you find the next weeks mont some time to review and decide how to continue on this. No hurry it is just that i came across your or somebody elses thoughts about adding support for mmap objects. I might have an idea/suggestion on how to add support for parsing any contigous blob of byte and want to give ti a try. I do thereby not want to mix things. |
|
Should read my own issue #9. According to my own finding precondition for this pr met. |
This was referenced Sep 13, 2022
This was referenced Nov 20, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my suggestion for resolving issue #13. The precondition is that python 2 support officially has ended as proposed solution is python3 only. It removes python 2 from tox.ini and appveyor.yml.
Awaiting your review and appreciating any input also regarding any suggestions on how to deal with commons which are currently str (utf8) only and additional tests which i should add, amend or improve
If necessary i'm fine to rebase to updated upstream head whenever you will merge an earlier pull request.
Apart from the purpose of this pull request and the small advice requested for in issue #14 may i suggest to enforce that tests are run in order of dependencies between modules? Currently some of the feature and issue tests are run before the unit tests for
simpleparse/generator.py,simpleparse.simpleparsegrammar.pyandsimpleparse/commonsmodules which are essential for proper operation of simple parse and have dependencies in the mentioned order. (The best of all worse solutions i have found in this context so far is prefixing test files bytest_NN_´ instead of plaintest_` )Would you be interested in a tox based github action for CI testing on linux and mac in addition to appveyor or even in replacement on windows too?