Signal pdu #4
Closed
Signal pdu #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
September 2, 2016 15:43
…ith 64-bit integers (no arithmetic, unfortunately) Completed InputStream.prototype.readLong()
…on to and from a buffer. readLong() and writeLong() implemented now.
…to determine how many oneByteChunks are to be added to this.data
…lass takes a single argument chunkSize to determine how many bytes long it should be, ie 2 produces a "TwoByteChunk" - usage doesn't change much: var foobar = new Chunk(4); foobar.initFromBinaryDIS(inputStream); this.data.push(foobar.otherParameters); Refactoring already complete.
…ding, the byte arrays are not parameters. Changed to simply read "data".
Missed three instances of OneByteChunk() corrected to use dis.Chunk(1)
|
@seanidzenga i merged this into the new home for this repository. https://github.com/open-dis/open-dis-javascript Feel free to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed implementation of the signal pdu - rather than using many nByteChunk functions I've implemented a Chunk class which takes a parameter for however many bytes you need.
new oneByteChunk() == new Chunk(1)
new sixByteChunk() == new Chunk(6)
etc...