Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning httpServer object from runServer #71

Closed
JakubPetriska opened this issue Aug 5, 2021 · 2 comments
Closed

Returning httpServer object from runServer #71

JakubPetriska opened this issue Aug 5, 2021 · 2 comments

Comments

@JakubPetriska
Copy link

Hello, first of all thanks for this amazing library. I'm using it in automated tests to test my SSO service provider implementation and it helped me a lot.

I have one issue though. As I'm starting the server for each automated test I'd like to kill the server at the end of each test. This is currently not possible as the runServer function does not return the httpServer object.

I already have this implemented on my machine and can submit PR. Would it be possible to add this to the library?

@Devlin556
Copy link

@JakubPetriska great idea, I just wanted to write about it :-D Thank you! I'm waiting for your implementation

@JakubPetriska
Copy link
Author

Nice, that's awesome. Here it is #72

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants