Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Overall Visual Consistency with Xcode #43

Open
austincondiff opened this issue Mar 14, 2022 · 1 comment
Open

More Overall Visual Consistency with Xcode #43

austincondiff opened this issue Mar 14, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@austincondiff
Copy link

austincondiff commented Mar 14, 2022

We seem to generally be following the editor visual style of Xcode. There are a few things that need to be addressed to get be more visually consistent. (left - Xcode, right - CodeEditorView)

image

  • Better syntax highlighting
  • Increased line height
  • Smaller and more narrow line number font.
  • General editor font styling is off (maybe smaller font size by 1px and increased font weight?).

image

image

  • General message styling (typography, iconography, colors, animation, dismiss popover button, etc) needs work
@austincondiff austincondiff changed the title Style to be more like Xcode More Overall Visual Consistency with Xcode Mar 14, 2022
@mchakravarty
Copy link
Owner

Let me address the points in turn:

  • Syntax highlighting: Xcode uses a two-phase system. There is the basic syntax highlighting that you'll get right away, and then (with a little delay), you get additional (semantic) highlighting that —I assume— is powered by information from SourceKit. The editor view itself can only do the basic syntactic part, as the rest requires information from a more sophisticated source code analysis (what SourceKit does). My plan is definitely for CodeEditorView also to be able to make use of additional semantic information (like the information provided by SourceKit or LSP), but that isn't implemented yet. This will need a design and one big question is how to represent that information. Make plan so far was to go with what LSP does, but I am open to better ideas.
  • The font issues should in the end all be configurable to keep CodeEditorView flexible. I think that will be quite easy to do. On the first go, I simply hardcoded some of these things, because that gave me a faster turnaround. There is already support for themes and these configuration details should probably go there.
  • Re message styling, we have Message view display improvements #3.

@mchakravarty mchakravarty added the enhancement New feature or request label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants