Skip to content

Commit

Permalink
rasdaemon: ARM: fully initialize ras_arm_event
Browse files Browse the repository at this point in the history
Issue found by covscan:

1. rasdaemon-0.4.1/ras-arm-handler.c:32: var_decl: Declaring variable "ev" without initializer.
16. rasdaemon-0.4.1/ras-arm-handler.c:81: uninit_use_in_call: Using uninitialized value "ev.error_count" when calling "ras_store_arm_record".
23. rasdaemon-0.4.1/ras-record.c:243:2: read_parm_fld: Reading a parameter field.

Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
  • Loading branch information
aristeu authored and mchehab committed Apr 25, 2018
1 parent 7789d5b commit e5a167b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ras-arm-handler.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ int ras_arm_event_handler(struct trace_seq *s,
struct tm *tm;
struct ras_arm_event ev;

memset(&ev, 0, sizeof(ev));

/*
* Newer kernels (3.10-rc1 or upper) provide an uptime clock.
* On previous kernels, the way to properly generate an event would
Expand Down

0 comments on commit e5a167b

Please sign in to comment.