The rasdaemon service may fail to be started for the first time. #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rasdaemon creates a separate instance virtual directory on first startup, like `/sys/kernel/debug/tracing/instances/rasdaemon`. After the directory is created, the kernel generates virtual files such as `trace_clock` and `set_event` in `/sys/kernel/debug/tracing/instances/rasdaemon`. The kernel generates virtual files and the rasdaemon accesses the virtual files at the same time. Therefore, the kernel may not generate the virtual files when the rasdaemon accesses the virtual files. So add a 100 ms delay to give the kernel enough time to generate the files. Signed-off-by: zhuofeng <zhuofeng2@huawei.com>
mchehab
requested changes
Jul 16, 2024
| char fname[MAX_PATH + 1]; | ||
|
|
||
| strcpy(fname, ras->tracing); | ||
| strcat(fname, "/"); | ||
| strcat(fname, name); | ||
|
|
||
| return open(fname, flags); | ||
| ret = wait_access(fname, 100); |
There was a problem hiding this comment.
Nothing warrants that 100ms is enough. I would setup it a way bigger, like 30 seconds, as having rasdaemon failing means that RAS instrumentation won't be in place.
Granted, on normal situations, this will be solved a way faster, but the server might be on high load. So, a long timeout won't hurt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rasdaemon creates a separate instance virtual directory on first startup, like
/sys/kernel/debug/tracing/instances/rasdaemon.After the directory is created, the kernel generates virtual files such as'trace_clock' and'set_event' in /sys/kernel/debug/tracing/instances/rasdaemon`.
The kernel generates virtual files and the rasdaemon accesses the virtual files at the same time. Therefore, the kernel may not generate the virtual files when the rasdaemon accesses the virtual files.
So add a 100 ms delay to give the kernel enough time to generate the files.