Updated the Python GTK widget to Python 3 and GTK 3. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of the Python wrapper around the GTK widget was written for Python 2 and GTK 2. Python 2 has been EOL for more than two years, but the widget is still very interesting. Also, the way to integrate GTK and Python has changed a lot during the years. So, the ZBarGtk widget type is registered automatically by gi, and the only needed step in the bindings is creating and returning the widget somehow. I also implemented the request video size functionality through new attributes: video-width and video-height. The only feature the Python wrapper is missing is the possibility to scan a GdkPixbuf, because I could not find a way to register a new method to the __gi__.ZBarGtk type without reimplementing it completely. Signed-off-by: Pier Angelo Vendrame <vogliadifarniente@gmail.com>
|
Sorry, I did not notice the GIR section on the README. I guess that this can be closed, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of the Python wrapper around the GTK widget was written for Python 2 and GTK 2.
Python 2 has been EOL for more than two years, but the widget is still very interesting.
Also, the way to integrate GTK and Python has changed a lot during the years.
So, the
ZBarGtkwidget type is registered automatically bygi, and the only needed step in the bindings is creating and returning the widget somehow.I also implemented the request video size functionality through new attributes:
video-widthandvideo-height.The only feature the Python wrapper is missing is the possibility to scan a
GdkPixbuf, because I could not find a way to register a new method to the__gi__.ZBarGtktype without reimplementing it completely.Please notice that I have sent this code to Tails, but it is missing the whole licensing comment. The reason is that, while
gitdetects it as a series of changes onpygtk/zbargtkmodule.c, it actually is a complete rewritten from scratch.In any case, I am the author also of that code.