Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalisation issue 34 #44

Closed
wants to merge 3 commits into from

Conversation

Ckrapock
Copy link
Contributor

No description provided.

@mchev
Copy link
Owner

mchev commented Feb 23, 2023

Can't merge this PR because there is errors in almost all .vue files

Example :
<div class="whitespace-nowrap" title="__('Language')">
should be :
<div class="whitespace-nowrap" :title="__('Language')">

@mchev mchev closed this Feb 23, 2023
@Ckrapock
Copy link
Contributor Author

Got it thanks @mchev !
Sorry about that, problem with "blind development" there.
I'll review and will create a new PR with syntax fixes. Hopefully next time that will be just a handful of issues left.

@Ckrapock
Copy link
Contributor Author

Ckrapock commented Feb 23, 2023

@mchev I only found 2 places with same pattern where I needed to add a ":"
The one you already mentioned, and this one below:
<text-input v-model="form.search" class="mr-4 w-full max-w-md" placeholder="__('Search in FAQ')"
That I changed in my branch into
<text-input v-model="form.search" class="mr-4 w-full max-w-md" :placeholder="__('Search in FAQ')"
But you said "almost all .vue files" are throwing errors. By any chance, would you have any other example of syntax changes to give me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants