Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlexCAN peripheral addition #124

Open
wants to merge 3 commits into
base: flexcan-integration
Choose a base branch
from
Open

FlexCAN peripheral addition #124

wants to merge 3 commits into from

Conversation

dstric-aqueduct
Copy link

@dstric-aqueduct dstric-aqueduct commented Dec 12, 2022 •
edited

This pull request adds functionality for the imxrt's FlexCAN1 and FlexCAN2 peripherals.

The update adds two examples of peripheral:

  • examples\can.rs - Example using Can1 in a standard "no-main" entry.
  • examples\rtic_can_log.rs - Example using Can1 in the RTIC runtime.

See corresponding PR for imxrt-hal crate: imxrt-rs/imxrt-hal#122

@dstric-aqueduct dstric-aqueduct mentioned this pull request Dec 12, 2022
Open
@mciantyre
Copy link
Owner

bors try

bors bot added a commit that referenced this pull request Dec 12, 2022
@bors
Try #124:
7efa12f
@bors
Copy link
Contributor

bors bot commented Dec 12, 2022

try

Build failed:

dstric-aqueduct and others added 2 commits December 14, 2022 16:43
@dstric-aqueduct
align Can builder with Pin trait convention
d176a6d
@mciantyre
Test CAN1 set_fifo_interrupt(false) behaviors
480dde4 
This commit corresponds to a FlexCAN PR review question in imxrt-hal.
I'm sharing it to make reproduction easier.

imxrt-rs/imxrt-hal#122 (comment)
@mciantyre mciantyre changed the base branch from master to flexcan-integration January 6, 2023 14:41
@collin80
Copy link

collin80 commented Feb 2, 2023

Cool! But, the Teensy 4 CPU technically has three CAN buses in hardware, not two. The third is CAN-FD capable. Are there any plans to support this?

@mciantyre
Copy link
Owner

FlexCAN3 is not available through the HAL, not even for CAN 2.0B functions. There's also no CANFD support in the proposed driver.

If you have a need for that third CAN network or CANFD, could you leave a note on the upstream PR? It'll reach a wider audience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dstric-aqueduct @mciantyre @collin80