Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #67

Closed
frozenshadow opened this issue Jul 27, 2018 · 13 comments
Closed

Localization #67

frozenshadow opened this issue Jul 27, 2018 · 13 comments

Comments

@frozenshadow
Copy link

Is there a possibility to translate/localize the validation messages (e.g. RequiredAttribute)?

@mcintyre321
Copy link
Owner

You'd have to extend it yourself, but I'm happy to accept pull requests for any functionality like that. What approach for translation are you using, resx?

@frozenshadow
Copy link
Author

Thanks for the quick reply.
Currently I'm not using any translations yet, but I think I'll go for resx.

I don't have any experience with translating C# applications/websites, so that will be a challenge 😉
Once I got it working I will make a PR.

@mcintyre321
Copy link
Owner

Are you doing asp.net MVC or asp.net core?

@frozenshadow
Copy link
Author

asp.net MVC

@frozenshadow
Copy link
Author

I made a working version for my project: https://github.com/frozenshadow/FormFactory.
Since I've never made a (NuGet) package before, I don't know what the requirements are.
So please let me know your thoughts ☺️

@mcintyre321
Copy link
Owner

mcintyre321 commented Jul 27, 2018 via email

@frozenshadow
Copy link
Author

frozenshadow commented Jul 27, 2018

No idea. Haven't tried, modified or used that one.
I only customized it for my own project (a Enterprise solution).

@mcintyre321
Copy link
Owner

It uses shared code from the main FormFactory project, so they both need to have been checked before I can pull the code into my repositoryy.

If you open your solution, and start each of the example projects, you should see the documentation site. If that works, I can safely merge the code, and then update the main FormFactory Nuget package.

@frozenshadow
Copy link
Author

frozenshadow commented Jul 27, 2018 via email

@mcintyre321
Copy link
Owner

mcintyre321 commented Jul 28, 2018 via email

@frozenshadow
Copy link
Author

Yeah sure, would love to!

I've just tested the MVC and Core examples. And it seems to be working ok.
But just to be safe, maybe you should also check it ;)

@mcintyre321
Copy link
Owner

I'm more a 'rollback if necessary' kinda guy :)

@frozenshadow
Copy link
Author

Haha!
You can sent me an invite for Slack if you want.
My mail is on my profile page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants