Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multilevel collections, browser compatibility tweak #34

Closed
wants to merge 40 commits into from
Closed

Multilevel collections, browser compatibility tweak #34

wants to merge 40 commits into from

Conversation

jhilyard
Copy link

(html encoded "add" forms, removed draggable)

Harry McIntyre and others added 30 commits July 12, 2016 12:23
Added section on programmatic form creation
13fd06a
@mcintyre321
Update _Layout.cshtml
4ceee74
@mcintyre321
Merge branch 'master' of https://github.com/mcintyre321/FormFactory
d7e0817
@mcintyre321
use form render scope
de6dc08
@mcintyre321
Excluded bower components
78156eb
Simplified the code behind the RazorGenerator implementation
fbbe114
Enabled c#6
1d56745
@mcintyre321
Added dynamic visibility
099cb6e
@mcintyre321
Enabled DataType(customDataType: "Radio") for strings
a76d0f0
@mcintyre321
Updated docs
14260a6
@mcintyre321
Enable custom enctype on forms
7f1922c
Refactored formvm model
7f7e0be
Merge branch 'master' of https://github.com/mcintyre321/FormFactory
0a67002 
# Conflicts:
#	FormFactory.Templates/Views/Shared/FormFactory/Form.Start.cshtml
#	FormFactory/FormVm.cs
Removed msbuild powered nuget
6eab7cc
Work in progress on DNC
6c6c211
Now loads in 451
3d351c8
More WIP
678afae
More WIP
b8de708
Removed helper functions as not supported in core :(
25aec9f
Version changes
fe9df4f
Version number
44ce37a
@mcintyre321
Removed nuget dependency
86209f7
Merge branch 'dotnetcore-wip' of https://github.com/mcintyre321/FormF…
6f54c14 
…actory into dotnetcore-wip

Don't use DotNetStandard on 451
Merge branch 'dotnetcore-wip' of https://github.com/mcintyre321/FormF…
f2dc716 
…actory into dotnetcore-wip
@mcintyre321
Added assets back into examples
371fb05
@mcintyre321
Added assets back into examples
4325414
@mcintyre321
Merge branch 'dotnetcore-wip' of https://github.com/mcintyre321/FormF…
4bbe451 
…actory into dotnetcore-wip
@mcintyre321
Renamed proj
2261a93
@mcintyre321
Added ignore bower files
315ba39
Fixed asset loading
e60a770
mcintyre321
mcintyre321 reviewed Nov 19, 2016
View reviewed changes
Copy link
Owner

@mcintyre321 mcintyre321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefix for this pull request! I haven't had a chance to review it fully yet, probably will have to wait until Monday.

I did notice the draggable attribute was removed, does drag n drop still work?

@mcintyre321
Copy link
Owner

Thanks, not prefix!

mcintyre321
mcintyre321 requested changes Nov 21, 2016
View reviewed changes
Copy link
Owner

@mcintyre321 mcintyre321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid I can't accept this PR as is,

reasons to accept:

  • nested collections working, hooray!
    reasons not to:
  • drag and drop (where supported) no longer works
  • not using script block to contain template (I remember having to do this to avoid encoding issues
  • ASP MVC demo site throws exception

If you could fix up those issues it should be AOK.

Are you using the collections feature? Have you reworked the style in your templates at all, I sometimes wonder if they need to be spruced up a bit...

@mcintyre321 mcintyre321 mentioned this pull request Feb 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcintyre321 mcintyre321 mcintyre321 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhilyard @mcintyre321