Skip to content

Commit

Permalink
Fix/lint (#73)
Browse files Browse the repository at this point in the history
* Hotfix/0.4.3 (#7) - Address broken links and grammar

* Fix documentation links in README (#2)

* Fix links in README

* library -> libraries

* Fix github link in docs

* Clean up grammar and consistency in documentation (#4)

* Clean up grammar and consistency in `README` files

* Add esses, mostly

* Reword feature description to not appear automatic

* Update docs/source/05_resources/05_faq.md

Co-Authored-By: Ben Horsburgh <benhorsburgh@outlook.com>

Co-authored-by: Ben Horsburgh <benhorsburgh@outlook.com>

* hotfix/0.4.3: fix broken links

Co-authored-by: Zain Patel <30357972+mzjp2@users.noreply.github.com>
Co-authored-by: Nikos Tsaousis <tsanikgr@users.noreply.github.com>
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>

* Release/0.5.0

* Plotting now backed by pygraphviz. This allows:
   * More powerful layout manager
   * Cleaner fully customisable theme
   * Out-the-box styling for different node and edge types
* Can now get subgraphs from StructureModel containing a specific node
* Bugfix to resolve issue when fitting CPDs with some missing states in data
* Minor documentation fixes and improvements

* Release/0.6.0

* Release/0.7.0 (#57)

* Added plottting tutorial to the documentation
* Updated `viz.draw` syntax in tutorial notebooks
* Bugfix on notears lasso (`from_numpy_lasso` and `from_pandas_lasso`) where the non-negativity constraint was not being set
* Added DAG-based synthetic data generator for mixed types (binary, categorical, continuous) using a linear SEM approach.
* Unpinned some requirements

* black

* pin pytorch version

* pin pytorch version

Co-authored-by: Ben Horsburgh <Ben.Horsburgh@quantumblack.com>
Co-authored-by: Zain Patel <30357972+mzjp2@users.noreply.github.com>
Co-authored-by: Nikos Tsaousis <tsanikgr@users.noreply.github.com>
Co-authored-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
  • Loading branch information
5 people committed Aug 11, 2020
1 parent b3a59e3 commit 2eb27dd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
4 changes: 1 addition & 3 deletions causalnex/inference/inference.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,7 @@ def template() -> float:
# initially there are none present, but caller will add appropriate arguments to the function
# getargvalues was "inadvertently marked as deprecated in Python 3.5"
# https://docs.python.org/3/library/inspect.html#inspect.getfullargspec
arg_spec = inspect.getargvalues( # pylint: disable=deprecated-method
inspect.currentframe()
)
arg_spec = inspect.getargvalues(inspect.currentframe())

return self._cpds[arg_spec.args[0]][ # target name
arg_spec.locals[arg_spec.args[0]]
Expand Down
2 changes: 1 addition & 1 deletion causalnex/network/network.py
Original file line number Diff line number Diff line change
Expand Up @@ -573,7 +573,7 @@ def _predict_probability_from_incomplete_data(
cols = []
pattern = re.compile("^{node}_[0-9]+$".format(node=node))
# disabled open pylint issue (https://github.com/PyCQA/pylint/issues/2962)
for col in probability.columns: # pylint: disable=E1133
for col in probability.columns:
if pattern.match(col):
cols.append(col)
probability = probability[cols]
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"pygraphviz>=1.5, <2.0",
],
"pytorch": [
"torch>=1.4.0, <2.0"
"torch>=1.4.0, <1.6"
]
}

Expand Down
2 changes: 1 addition & 1 deletion test_requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ pylint>=2.5.2, <3.0
pytest-cov>=2.5, <3.0
pytest-mock>=1.7.1,<2.0
pytest>=4.3.0,<5.0
torch>=1.4.0, <2.0
torch>=1.4.0, <1.6

0 comments on commit 2eb27dd

Please sign in to comment.