Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise misplaced columns in dynotears estimation, and fix a minor bug in dataset generation. #119
base: develop
Are you sure you want to change the base?
Revise misplaced columns in dynotears estimation, and fix a minor bug in dataset generation. #119
Changes from 1 commit
1ed7976
b9b5e4d
1c56978
eb61fff
32372c1
e734905
d128d82
0e39493
36727b5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted
accepts a generator expression, doesn't need to (waste memory!) coercing it into a list first :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted(el for el in g.nodes if "_lag0" not in el)
will lead to misplaced columns, e.g.[0_lag1, 0_lag2, 0_lag3, 1_lag1, 1_lag2, 1_lag3, 2_lag1, 2_lag2, 2_lag3]
(node first, then lag, case1). But the dynotears model accepts columns like[0_lag1, 1_lag1, 2_lag1, 0_lag2, 1_lag2, 2_lag2, 0_lag3, 1_lag3, 2_lag3]
(lag first, then node, case2). The defaultsorted
expression takes a case1 style. I've test the revised code using the code below.__test__.py