Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS alignment bugs and add more templates #106

Merged
merged 14 commits into from
Oct 11, 2023
Merged

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Oct 11, 2023

Description

  • Fix alignment between control panel, dashboard title and page title
  • Fix padding misalignment caused by scroll bar placeholder
  • Fix dashboard title position if text is long
  • Add template for waterfall chart type
  • Add default CSS styling for textarea

Note: @l0uden is currently updating the screenshots for the last ci test to pass

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@huong-li-nguyen huong-li-nguyen self-assigned this Oct 11, 2023
@huong-li-nguyen huong-li-nguyen added the Issue: Bug Report 🐛 Issue/PR that report/fix a bug label Oct 11, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review October 11, 2023 10:45
@huong-li-nguyen huong-li-nguyen added the Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed label Oct 11, 2023
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! 💯

There's just one thing I spotted -> html.Hr isn't visible between accordion and controls if the last page is selected in the accordion.

@huong-li-nguyen
Copy link
Contributor Author

It looks good! 💯

There's just one thing I spotted -> html.Hr isn't visible between accordion and controls if the last page is selected in the accordion.

Ah yeah, the html.Hr is not visible because the selected color is overlapping. I think that's fine for now, because otherwise we wouldn't adhere to the correct padding between the horizontal ruler and the field. I'll add that to the ticket of things for Dan to double-check when reviewing all the designs again.

Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good. 🚀 🧙

@huong-li-nguyen huong-li-nguyen merged commit 76c775e into main Oct 11, 2023
21 of 22 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/fix_css_bugs branch October 11, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants