-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSS alignment bugs and add more templates #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! 💯
There's just one thing I spotted -> html.Hr
isn't visible between accordion and controls if the last page is selected in the accordion.
vizro-core/changelog.d/20231011_110304_huong_li_nguyen_fix_css_bugs.md
Outdated
Show resolved
Hide resolved
Ah yeah, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. 🚀 🧙
Description
textarea
Note: @l0uden is currently updating the screenshots for the last ci test to pass
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":