Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vm.Slider and vm.RangeSlider to work with incorrect textual input #173

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

petar-qb
Copy link
Contributor

Description

Fixed vm.Slider and vm.RangeSlider to work with incorrect text input.

Screenshot

Example on the main branch:
https://github.com/mckinsey/vizro/assets/108530920/455e6d69-beb3-43d5-a4b4-50eef5900f94

Example on the bugs/fix_sliders_incorrect_input branch:
https://github.com/mckinsey/vizro/assets/108530920/bf884f34-ec3e-4d9a-bfec-80b399229745

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@petar-qb petar-qb added Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed Issue: Bug Report 🐛 Issue/PR that report/fix a bug labels Nov 14, 2023
@petar-qb petar-qb self-assigned this Nov 14, 2023
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 🙏

@petar-qb petar-qb merged commit f8c7cf9 into main Nov 14, 2023
33 checks passed
@petar-qb petar-qb deleted the bugs/fix_sliders_incorrect_input branch November 14, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants