Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of the custom actions #178

Merged
merged 18 commits into from
Dec 6, 2023
Merged

Release of the custom actions #178

merged 18 commits into from
Dec 6, 2023

Conversation

petar-qb
Copy link
Contributor

Description

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@petar-qb petar-qb self-assigned this Nov 24, 2023
Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you very much @petar-qb!

Just small comments and questions on the code implementation, but all the tests cases look great so I'm happy that the behaviour is all as expected 👍 Really great work on the tests.

I want to review the documentation also so won't approve yet but no major changes needed on the code 👍

vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
vizro-core/src/vizro/models/_action/_action.py Outdated Show resolved Hide resolved
vizro-core/tests/unit/vizro/models/_action/test_action.py Outdated Show resolved Hide resolved
@petar-qb
Copy link
Contributor Author

petar-qb commented Dec 4, 2023

@antonymilne do you think we should use Ellipsis instead of "outputs" as namedtuple typename in internal usage (because namedtuple typename means nothing to us):
namedtuple("outputs", [])(**{}) -> namedtuple(..., [])(**{})

@antonymilne
Copy link
Contributor

antonymilne commented Dec 4, 2023

@antonymilne do you think we should use Ellipsis instead of "outputs" as namedtuple typename in internal usage (because namedtuple typename means nothing to us): namedtuple("outputs", [])(**{}) -> namedtuple(..., [])(**{})

I see what you mean and considered this before and decided this is not a good idea. In fact we should do namedtuple("Outputs", ...) with capital O to be a bit more consistent with convention.

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some updates to the docs in f3ac937 - please can you check it's all good?

After that I think it would be great if we could also have a screenshot for both of the clickData custom action examples, and let's move this to a new docs page like @Joseph-Perkins suggested.

I'll answer the remaining unresolved code conversations separately since they're very minor.

Thank you for all your work on this, it's amazing! 🙏

@petar-qb
Copy link
Contributor Author

petar-qb commented Dec 5, 2023

@antonymilne Thanks a lot on f3ac937 - Docs look much better now 📝 🤩.

@petar-qb petar-qb merged commit 444a581 into main Dec 6, 2023
33 checks passed
@petar-qb petar-qb deleted the feat/enable_custom_actions branch December 6, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants