Tidy hidden Divs and default values

[antonymilne]

Description

No change to functionality; just a small tidy. Seems a bit pointless, but it will make it easier to clean up some tests in a following PR...

• prefer to use None over html.Div(hidden=True) in the case that we don't need to refer to the element in any way (basically whenever you don't set an id). e.g. html.P(self.title) if self.title else None
• prefer to use html.Div(hidden=True) over None in the case that we do need to refer to the element (basically when you do set an id). e.g. html.Div(hidden=True, id="nav_panel_outer"). Generally these can be identified by the fact that build return values have a type like _NavBuildType
• prefer to use "" as default value for optional fields which are str. These fields do not need to accept None values at all

Checklist

• I have not referenced individuals, products or companies in any commits, directly or indirectly
• I have not added data or restricted code in any commits, directly or indirectly
• I have updated the docstring of any public function/class/model changed
• I have added tests to cover my changes (if applicable)

Types of changes

• Docs/refactoring (non-breaking change which improves codebase)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Notice

• I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
  • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

[lingyielia]

Thanks for the house-keeping! Is there a way for us to record this type of coding standards? So for future components to come, we can be consistent in terms of best practices

[nadijagraca]

Thanks for tidying it up. 🚀

[antonymilne]

Thanks for the house-keeping! Is there a way for us to record this type of coding standards? So for future components to come, we can be consistent in terms of best practices

Great question. I used to have various bits of documentation on this but they're a bit scattered and out of date. Let me make a ticket to consolidate and update them because definitely it would be useful 👍