Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default font color from global CSS to enable overwrites #213

Merged
merged 12 commits into from
Dec 14, 2023

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Dec 13, 2023

Description

Bug: Font color in data table could not be updated via style_data_conditional

  • Removes default font color from global CSS to enable overwrites
  • Assigns local font color in relevant CSS classes

Screenshot

Screenshot 2023-12-13 at 18 50 57

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@huong-li-nguyen huong-li-nguyen self-assigned this Dec 13, 2023
@huong-li-nguyen huong-li-nguyen added the Issue: Bug Report 🐛 Issue/PR that report/fix a bug label Dec 13, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review December 13, 2023 17:57
@huong-li-nguyen huong-li-nguyen added the Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed label Dec 13, 2023
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Hope it wasn't too bad for finding all these cases...

Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing it. 🚀

@huong-li-nguyen huong-li-nguyen merged commit ba5511b into main Dec 14, 2023
33 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/enable_color_overwrite branch December 14, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants