Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of invisible button inside Card #236

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Dec 22, 2023

Description

  • If a large image is provided the invisible button inside the Card is not positioned correctly and can lead to unnecessary scrolling and missing areas for clicking

Screenshot 2023-12-22 at 09 23 27

Screenshot

The invisible Button should now cover the entire area of the Card:
Screenshot 2023-12-22 at 09 14 36

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen self-assigned this Dec 22, 2023
@huong-li-nguyen huong-li-nguyen added the Issue: Bug Report 🐛 Issue/PR that report/fix a bug label Dec 22, 2023
@huong-li-nguyen huong-li-nguyen changed the title Fix position of invisible Button Fix position of invisible button inside Card Dec 22, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review December 22, 2023 08:24
@huong-li-nguyen huong-li-nguyen added the Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed label Dec 22, 2023
Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this bug so quickly!
This looks good to me.

Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@huong-li-nguyen huong-li-nguyen merged commit 81451d3 into main Dec 22, 2023
33 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/fix_invisible_button branch December 22, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants