Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snyk] Security upgrade kedro from 0.18.14 to 0.19.3 #345

Closed
wants to merge 2 commits into from
Closed

[Snyk] Security upgrade kedro from 0.18.14 to 0.19.3 #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dbfabe
fix: vizro-core/snyk/requirements.txt to reduce vulnerabilities
snyk-bot Mar 4, 2024
4b4d26b
Upgrade Kedro and remove redundant dependency
huong-li-nguyen Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions vizro-core/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ requires-python = ">=3.8"

[project.optional-dependencies]
kedro = [
"kedro>=0.17.3",
"kedro-datasets", # no longer a dependency of kedro for kedro>=0.19.2
"kedro>=0.19.3", # pinned by Snyk to avoid a vulnerability: https://security.snyk.io/vuln/SNYK-PYTHON-KEDRO-6370687
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen Mar 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took out kedro-datasets given that we need to upgrade to kedro>=0.19.2, but based on the failing unit tests, seems like we still need it? Where do we actually stand on the whole snyk discussion @antonymilne ? 🤔 Do we continue merging these proposals by snyk or do we selectively choose which ones we include?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm working out a scheme for handling these better, which will basically mean ignoring most, if not all, of snyk's suggested bumps or turning off the feature altogether.

Before that's ready, let's continue merging them where it's easy and looks sensible to do so and ignore them where it doesn't. This is definitely a case where it doesn't. Let's just ignore the PR for now and I'll handle it in due course...

"wheel>=0.38.0", # not directly required, pinned by Snyk to avoid a vulnerability: https://security.snyk.io/vuln/SNYK-PYTHON-WHEEL-3180413,
"ipython>=8.10.0", # not directly required, pinned by Snyk to avoid a vulnerability: https://app.snyk.io/vuln/SNYK-PYTHON-IPYTHON-3318382
"tornado>=6.3.2" # not directly required, pinned by Snyk to avoid a vulnerability: https://security.snyk.io/vuln/SNYK-PYTHON-TORNADO-5537286
Expand Down
3 changes: 1 addition & 2 deletions vizro-core/snyk/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ dash_mantine_components
numpy>=1.22.2
setuptools>=65.5.1
werkzeug>=3.0.1
kedro>=0.17.3
kedro-datasets
kedro>=0.19.3
wheel>=0.38.0
ipython>=8.10.0
tornado>=6.3.2
Loading