Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Replace RadioItems and Checklist #414

Merged
merged 79 commits into from
Apr 18, 2024
Merged

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Apr 10, 2024

Description

  • Add new Bootstrap CSS file with RadioItems and Checklist added
  • Remove all custom CSS related to these two components
  • Refactor RadioItems and Checklist to use semantically correct Fieldset and Legend, for context see: https://accessibility.blog.gov.uk/2016/07/22/using-the-fieldset-and-legend-elements/
  • Remove redundant input-container class from selectors to consolidate gaps
  • Add another unit test for Card (for context: I broke it during this PR at some point, but there was no test covering it)

TO DO

Screenshot

Run features demo dashboard:

Screenshot 2024-04-17 at 12 57 24

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

huong-li-nguyen and others added 30 commits March 25, 2024 10:30
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.I like the use of html.Fieldset. 🚀

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ LGTM!

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) April 18, 2024 11:20
@huong-li-nguyen huong-li-nguyen merged commit a25c395 into main Apr 18, 2024
34 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/replace_radio_item branch April 18, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants