Adjusting User guide structure #42
Merged
+497
−424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxschulz-COL
commented
Sep 18, 2023
| @@ -9,7 +9,7 @@ The [`Dashboard`][vizro.models.Dashboard] model accepts the `pages` argument, wh | |||
|
|
|||
| A [`Page`][vizro.models.Page] is split up into three main containers: | |||
|
|
|||
| 1. The **control container** where you can add your [Controls](control.md) to interact with the dashboard | |||
| 1. The **control container** where you can add your `controls` (see e.g. [Filters](filters.md) or [Parameters](parameters.md)) to interact with the dashboard | |||
There was a problem hiding this comment.
@nadijagraca I think this needs to be updated as we now have dedicated navigation right?
There was a problem hiding this comment.
Yes, this needs to be updated to reflect the fact we have a navigation container now as well.
There was a problem hiding this comment.
Could you add this to your PR on the images?
maxschulz-COL
requested review from
Joseph-Perkins,
chiara-sophie,
petar-qb and
nadijagraca
chiara-sophie
previously approved these changes
Sep 18, 2023
maxschulz-COL
added
Status: Ready for Review ☑️
chiara-sophie
previously approved these changes
Sep 20, 2023
Co-authored-by: Chiara Pullem <94166847+chiara-sophie@users.noreply.github.com>
Co-authored-by: Chiara Pullem <94166847+chiara-sophie@users.noreply.github.com>
Co-authored-by: Chiara Pullem <94166847+chiara-sophie@users.noreply.github.com>
Co-authored-by: Chiara Pullem <94166847+chiara-sophie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))(if applicable)Types of changes