-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tidy] Update dashboard layout #433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reduce icon bar width - Reduce title bar height - Reduce width of control panel - Consolidate default gaps
for more information, see https://pre-commit.ci
huong-li-nguyen
commented
Apr 22, 2024
nadijagraca
reviewed
Apr 23, 2024
nadijagraca
reviewed
Apr 23, 2024
nadijagraca
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really sleek. 🚀
Joseph-Perkins
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Tidy/Refactoring 🧹
Issue/PR that refactor existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For reviewers
@Joseph-Perkins should be the main reviewer of the layout changes.
I would suggest to do the following:
hatch run example demo
and check the current version vs.vizro.mckinsey.com
hatch run example demo
but remove the logo from the assets folder and any custom CSSScreenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":