Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Update dashboard layout #433

Merged
merged 24 commits into from
Apr 25, 2024
Merged

[Tidy] Update dashboard layout #433

merged 24 commits into from
Apr 25, 2024

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Apr 22, 2024

Description

  • Closes several tasks from this ticket: https://github.com/McK-Internal/vizro-internal/issues/721
    • Reduce icon bar width
    • Reduce title bar height
    • Reduce width of control panel
    • Set height for logo
    • Consolidate default gaps
    • Align table titles with figure titles
    • Align accordion title with filter titles
    • Update accordion styling for active item
    • Add indentation to accordion
    • Reduce graph margins

For reviewers

@Joseph-Perkins should be the main reviewer of the layout changes.

I would suggest to do the following:

  • Run hatch run example demo and check the current version vs. vizro.mckinsey.com
  • Run hatch run example demo but remove the logo from the assets folder and any custom CSS

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen self-assigned this Apr 22, 2024
@huong-li-nguyen huong-li-nguyen added the Tidy/Refactoring 🧹 Issue/PR that refactor existing code label Apr 22, 2024
@huong-li-nguyen huong-li-nguyen added the Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed label Apr 23, 2024
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review April 23, 2024 14:31
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really sleek. 🚀

@huong-li-nguyen huong-li-nguyen enabled auto-merge (squash) April 25, 2024 13:50
@huong-li-nguyen huong-li-nguyen merged commit c043276 into main Apr 25, 2024
34 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tidy/update_layout branch April 25, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed Tidy/Refactoring 🧹 Issue/PR that refactor existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants