-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Return fig object by VizroAI plot function #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's change the function name bit after changing it to return fig directly? something like _exec_code_and_retrieve_fig, but feel free to change it to other if it suits more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to ensure that all the docs are up-to-date as well!
For instance, this https://vizro--438.org.readthedocs.build/projects/vizro-ai/en/438/pages/user-guides/run-vizro-ai/#python-script would need to change e.g.
I would probably rebase this PR on the big docs changes, and then see that these new changes are coherent.
Otherwise very exciting change!
vizro-ai/changelog.d/20240426_164549_nadija_ratkusic_graca_vizro_ai_return_fig_object.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for addressing comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! There are a few things that we should change in the near future, but they are not breaking, so let's delay until after the release.
This would involve:
- adjusting the docs regarding the application integration
- renaming of private methods to be more intuitive
- settling on the question of how a user should get the chart code only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌟
Just a couple of minor tweaks as suggestions.
Description
.plot()
function ofVizroAI
now returns fig object (go.Figure type) by default. Returned fig objected can be used within Vizro dashboard.Changes to ux:
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":