-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing fetching action function name from action_functions dictionary. #46
Merged
petar-qb
merged 8 commits into
main
from
feature/1057/enable_custom_actions_unofficially
Sep 21, 2023
Merged
Removing fetching action function name from action_functions dictionary. #46
petar-qb
merged 8 commits into
main
from
feature/1057/enable_custom_actions_unofficially
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxschulz-COL
previously approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Thanks
vizro-core/changelog.d/20230921_075648_petar_pejovic_enable_custom_actions_unofficially.md
Outdated
Show resolved
Hide resolved
maxschulz-COL
added
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Issue: Bug Report 🐛
Issue/PR that report/fix a bug
labels
Sep 21, 2023
…stom_actions_unofficially.md Co-authored-by: Maximilian Schulz <83698606+maxschulz-COL@users.noreply.github.com>
…/1057/enable_custom_actions_unofficially
vizro-core/changelog.d/20230921_075648_petar_pejovic_enable_custom_actions_unofficially.md
Outdated
Show resolved
Hide resolved
nadijagraca
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
maxschulz-COL
approved these changes
Sep 21, 2023
petar-qb
deleted the
feature/1057/enable_custom_actions_unofficially
branch
September 21, 2023 11:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Issue: Bug Report 🐛
Issue/PR that report/fix a bug
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now, users are able to create their own custom actions in a following way:
Screenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes