Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Make changelog not required for docs changes and tidy licence files #480

Merged
merged 7 commits into from
May 15, 2024

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented May 14, 2024

Description

At the moment, any PR that touches files inside vizro-core or vizro-ai requires a new changelog fragment there. This is annoying for people who just want to make quick and easy docs changes (which never need a changelog entry) and also awkward with our current CODEOWNERS setup.

I've changed the logic so that if no file outside docs has been touched then the changelog fragment shouldn't be required any more.

I haven't been able to test this out fully, so there's definitely a chance my GHA/Bash scripting is slightly wrong, but we'll find out as soon as we make PRs. @stichbury this should hopefully make your life a bit easier since it means you don't need to run hatch run changelog:add any more and if someone else modifies only docs then your approval should be all that's needed to satisfy the CODEOWNERS requirement.

Also made all licence files .txt format (previously one was .md but it actually wasn't written in .md) and copied the text straight off https://www.apache.org/licenses/LICENSE-2.0.txt. It's the same text as before, just slightly different indentation. Is this what you were referring to in standup @petar-qb?

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@antonymilne antonymilne changed the title [Tidy/random bits [Tidy] Make changelog not required for docs changes and tidy licence files May 14, 2024
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thanks for this. I won't approve it as I don't know anything about the code but 👍 from me.

Copy link
Contributor

@petar-qb petar-qb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHA changes look good. 🎉


Is this what you were referring to in standup @petar-qb?

Yes, exactly. Thanks for adjusting that. 👍

@antonymilne antonymilne merged commit 3d4074e into main May 15, 2024
35 of 40 checks passed
@antonymilne antonymilne deleted the tidy/random-bits branch May 15, 2024 17:30
@antonymilne antonymilne mentioned this pull request Jul 11, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants