Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fixing dash_data_table dropdown menu to open on click #481

Merged
merged 5 commits into from
May 15, 2024

Conversation

petar-qb
Copy link
Contributor

Description

Solving https://github.com/McK-Internal/vizro-internal/issues/934

Run the _dev/examples/app.py example from the main and bug/fixing_dash_table_dropdown_menu branches to see the difference when trying to open a table dropdown cell.

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Kudos on finding a solution for this tricky issue. 🚀 ⭐

petar-qb and others added 3 commits May 15, 2024 14:39
…sh_table_dropdown_menu.md

Co-authored-by: Antony Milne <49395058+antonymilne@users.noreply.github.com>
Signed-off-by: Petar Pejovic <108530920+petar-qb@users.noreply.github.com>
@petar-qb petar-qb merged commit 1cc8ebe into main May 15, 2024
34 checks passed
@petar-qb petar-qb deleted the bug/fixing_dash_table_dropdown_menu branch May 15, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants