-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ValueError in Filter and add unit test for it #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0599dc2.
- Add tests for shared column with inconsistent dtype - Move test_set_actions to TestPreBuildMethod class
huong-li-nguyen
added
Tests 🧪
Issue/PR that address test framework
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
labels
Sep 26, 2023
huong-li-nguyen
requested review from
petar-qb,
nadijagraca,
lingyielia,
chiara-sophie and
Anna-Xiong
September 26, 2023 09:56
maxschulz-COL
previously approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
vizro-core/changelog.d/20230926_103636_huong_li_nguyen_add_tests_filter.md
Outdated
Show resolved
Hide resolved
petar-qb
reviewed
Sep 26, 2023
maxschulz-COL
approved these changes
Sep 26, 2023
petar-qb
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Tests 🧪
Issue/PR that address test framework
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
is_period_dtype
withisinstance(xxx, pd.PeriodDtype)
asis_period_dtype
will be deprecatedtest_set_slider_values_shared_column_inconsistent_dtype
Minor changes:
test_set_actions
to FilterPreBuild classScreenshot
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":