Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueError in Filter and add unit test for it #64

Merged
merged 12 commits into from
Sep 26, 2023

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Sep 26, 2023

Description

  • Replace is_period_dtype with isinstance(xxx, pd.PeriodDtype) as is_period_dtype will be deprecated
  • Improve ValueError for incompatible column_type and selector choice
  • Fix ValueError to be properly raised in case shared columns have different dtypes (if statement failed running before)
  • Add unit tests test_set_slider_values_shared_column_inconsistent_dtype

Minor changes:

  • Remove redundant TODOs
  • Add venv folder to whitelisted directories, otherwise we get false positives from site packages
  • Move test_set_actions to FilterPreBuild class

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@huong-li-nguyen huong-li-nguyen added Tests 🧪 Issue/PR that address test framework Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed labels Sep 26, 2023
@huong-li-nguyen huong-li-nguyen self-assigned this Sep 26, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review September 26, 2023 09:55
maxschulz-COL
maxschulz-COL previously approved these changes Sep 26, 2023
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@huong-li-nguyen huong-li-nguyen merged commit 583e951 into main Sep 26, 2023
22 of 24 checks passed
@huong-li-nguyen huong-li-nguyen deleted the tests/update_tests_filter branch September 26, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed Tests 🧪 Issue/PR that address test framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants