Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade pydantic from 1.10.13 to 2.4.0 #83

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

lingyielia
Copy link
Contributor

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `pip` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • vizro-core/snyk/requirements.txt
⚠️ Warning
pandas 1.3.5 requires numpy, which is not installed.

Vulnerabilities that will be fixed

By pinning:
Severity Priority Score (*) Issue Upgrade Breaking Change Exploit Maturity
medium severity 658/1000
Why? Proof of Concept exploit, Recently disclosed, Has a fix available, CVSS 5.3
Regular Expression Denial of Service (ReDoS)
SNYK-PYTHON-PYDANTIC-5907722
pydantic:
1.10.13 -> 2.4.0
No Proof of Concept

(*) Note that the real score may have changed since the PR was raised.

Some vulnerabilities couldn't be fully fixed and so Snyk will still find them when the project is tested again. This may be because the vulnerability existed within more than one direct dependency, but not all of the affected dependencies could be upgraded.

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

The following vulnerabilities are fixed by pinning transitive dependencies:
- https://snyk.io/vuln/SNYK-PYTHON-PYDANTIC-5907722
@huong-li-nguyen
Copy link
Contributor

huong-li-nguyen commented Oct 1, 2023

Migration to pydantic v2 is planned end of this year/start of next year, so we won't be able to solve this one until we've migrated. We can prioritise the migration depending on the remaining features planned this year @Joseph-Perkins @lingyielia

@antonymilne
Copy link
Contributor

antonymilne commented Oct 2, 2023

I think this synk report is wrong since the fix for this has been backported to pydantic 1.1.0.13.

If we wanted to then we could move to pydantic>=1.10.13, <2 but personally I wouldn't bother because this exploit does not actually affect us in any meaningful way.

@lingyielia
Copy link
Contributor Author

lingyielia commented Oct 2, 2023

If we wanted to then we could move to pydantic>=1.10.13, <2

Like this idea, it's suggested by Snyk as well:

https://security.snyk.io/vuln/SNYK-PYTHON-PYDANTIC-5907722

How to fix?
Upgrade pydantic to version 1.10.13, 2.4.0 or higher.

@antonymilne
Copy link
Contributor

Ah yes, I think that Snyk page has changed since about an hour ago since it just used to say that 2.4.0 was the only fixed version.

@huong-li-nguyen
Copy link
Contributor

huong-li-nguyen commented Oct 2, 2023

I'll push it to this PR.

@huong-li-nguyen huong-li-nguyen added Component: DevOps/Setup 🏛️ Issue/PR that addresses automation, CI, GitHub setup, technical setup of the project repository Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed labels Oct 2, 2023
@huong-li-nguyen huong-li-nguyen merged commit bab186f into main Oct 3, 2023
25 checks passed
@huong-li-nguyen huong-li-nguyen deleted the snyk-fix-45c953e9ecaac62cbefac81184742ed1 branch October 3, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: DevOps/Setup 🏛️ Issue/PR that addresses automation, CI, GitHub setup, technical setup of the project repository Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants