Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make horizontal rulers visible #91

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Oct 3, 2023

Description

  • Make horizontal rulers visible
  • Replace html.Div(className="keyline") with html.Hr()
  • Update Codeowners

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added the PR number to the change description in the changelog fragment, e.g. Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1)) (if applicable)
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@huong-li-nguyen huong-li-nguyen changed the title Make horizontal rulers visible Make horizontal rulers visible in Card Oct 3, 2023
@huong-li-nguyen huong-li-nguyen changed the title Make horizontal rulers visible in Card Make horizontal rulers visible Oct 3, 2023
@huong-li-nguyen huong-li-nguyen self-assigned this Oct 3, 2023
@huong-li-nguyen huong-li-nguyen added Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed labels Oct 3, 2023
@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review October 3, 2023 10:06
@huong-li-nguyen huong-li-nguyen merged commit 23c3697 into main Oct 3, 2023
25 checks passed
@huong-li-nguyen huong-li-nguyen deleted the bug/make_rulers_visible branch October 3, 2023 11:25
@huong-li-nguyen huong-li-nguyen mentioned this pull request Oct 3, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report 🐛 Issue/PR that report/fix a bug Status: Ready for Review ☑️ Issue/PR is ready for review - all tests have passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants