-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug so that add_type
updates forward references in new type added
#92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huong-li-nguyen
changed the title
Fix bug on
Fix bug on Oct 4, 2023
Child.update_forward_refs
having to be calledChildWithForwardRef.update_forward_refs
having to be called
huong-li-nguyen
added
Issue: Bug Report 🐛
Issue/PR that report/fix a bug
Component: Docs 🗒️
Issue/PR for markdown and API documentation
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
labels
Oct 4, 2023
huong-li-nguyen
requested review from
Joseph-Perkins,
antonymilne and
maxschulz-COL
as code owners
October 4, 2023 11:41
antonymilne
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for finishing this off! 💯 Just some minor suggestions.
vizro-core/changelog.d/20231004_131631_huong_li_nguyen_fix_child_forwardref.md
Outdated
Show resolved
Hide resolved
huong-li-nguyen
changed the title
Fix bug on
Fix bug so that Oct 4, 2023
ChildWithForwardRef.update_forward_refs
having to be calledadd_type
updates forward references in new type added
maxschulz-COL
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Great fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Docs 🗒️
Issue/PR for markdown and API documentation
Issue: Bug Report 🐛
Issue/PR that report/fix a bug
Status: Ready for Review ☑️
Issue/PR is ready for review - all tests have passed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ChildWithForwardRef.update_forward_refs
having to be calledScreenshot
Without the fix, the unit tests will fail on this:
Checklist
Enable feature XXX ([#1](https://github.com/mckinsey/vizro/pull/1))
(if applicable)Types of changes
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":